-
Notifications
You must be signed in to change notification settings - Fork 3k
docs: batch docs issues #13823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: batch docs issues #13823
Conversation
…or nodemailer and resend
- Adds comment to ImageMedia component in website template for loader - adds example for dynamic admin thumbnail
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick but across all of these code blocks you should add ts
so it's highlighted correctly
Like so
```ts
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you had split out the email/overview.mdx changes I would have approved it and merged just that part.
used as a GraphQL enum. | ||
</Banner> | ||
|
||
### Limitations for Arrays / Nested Fields (especially on MongoDB) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we discussing array
and block
field limitations inside of the select field docs page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this update was meant to provide clarity regarding this: #12836
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but this is only added to select
. If we are going to add it to one field we should add it to all fields, OR we make the decision to put it somewhere on the blocks
or array
docs pages for those fields. Right?
I can run into this problem if I use array
with text
fields and that has nothing to do with the select
field which is why I've asked this question.
docs/upload/overview.mdx
Outdated
{ | ||
name: 'thumbnailURL', | ||
type: 'text', | ||
admin: { readOnly: true, condition: () => false }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should just be admin.hidden: true
instead of using the condition. Also readOnly: true
isn't necessary if your field is hidden anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
} | ||
``` | ||
|
||
3. Dynamic thumbnails via hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you use this method over the 2nd method? That should be explained in the docs if there is a good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #11453
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want you to link me to the reason. I'm saying as somebody reading our docs, it needs to be made clear what why this method could be useful.
Updates documentation for the following:
#12836-updates docs around unique true on select field
#12813-adds example for sending emails with attachments for nodemailer + resend
#12147-updates node version in dockerfile in production docs
#12105 - adds comment in image component inside website template for loader prop
#11453-updates docs with example for dynamic adminThumbnail